Open YifanC opened 8 months ago
Yes, in general we should add a field to the charge/event object that tags which event builder built the particular event. Then for 2x2 we first run over with the beam trigger event builder, make all the events we can, and tag them as beam trigger events. And then, e.g., run over the remaining packets and build as many LRS threshold trigger events as we can, and tag them as threshold trigger events. And then another pass with something like the symmetric window event builder, and tag them as such. Etc.
Side note: for events like the ones you have in the attached event displays, it’s possible that we could still match this with a light event and correct the event time with the associated t0. I guess this would mostly occur when there is some inefficiency in the pacman receiving the threshold trigger signal from LRS. In principle, this shouldn’t happen, but I seem to remember this happening in the single module runs in some instances. (We should try and catch this in DQM.)
When we use
SymmetricWindowRawEventBuilder
, if there's no external trigger, the time of the first arrival hit is considered as event t0, which can be horrendously wrong.