DVDAndroid / XposedInstaller

Materialised Xposed Installer
https://forum.xda-developers.com/xposed/material-design-xposed-installer-t3137758
269 stars 57 forks source link

Long module version names misshape card layout #137

Closed wasdennnoch closed 8 years ago

wasdennnoch commented 8 years ago

For example, the automated builds of Android N-ify have a very long version name. This revealed a little layout issue of the module card:

screenshot_20160918-200414

The version text takes up the full width so the app name needs several lines. It also is too small to be visible. Fixing methods: Set the max lines of the app name to 2/3, give the version TextView a max width. Also the LinearLayout they are in should have an orientation attribute for better readability ;)

And yes, the version name really should be shorter, but the installer should also be compatible :P

DVDAndroid commented 8 years ago

Can you provide me the apk? I downloaded it from Jenkins but the bug is not visible. Should I build it from Android studio manually?

screenshot_20160918-202833 2

DVDAndroid commented 8 years ago

(I can always create an empty module with long version name)

wasdennnoch commented 8 years ago

The experimental builds have the long name: https://ci.paphonb.xyz/jenkins/job/AndroidN-ify_experimental/

DVDAndroid commented 8 years ago

Now the textview of version name is animated if too long and it has a max width of 100dp

rovo89 commented 8 years ago

To me, the animation gives the screen a nervous touch. Such a long version name isn't a good idea anyway. So I think it's better just to limit the width and ellipsize in the middle of the text. That way, the beginning and the end are still visible.