DVDAndroid / XposedInstaller

Materialised Xposed Installer
https://forum.xda-developers.com/xposed/material-design-xposed-installer-t3137758
269 stars 57 forks source link

Module update detection bug #194

Open MPeti1 opened 6 years ago

MPeti1 commented 6 years ago
Include the following:
Reproduction Steps
  1. install an update to your Xposed module from Android Studio, do it over wifi if possible
  2. wait until module is installed and it's main Activity starts
  3. wait some more
Expected Result

Xposed Installer should send a notification that a module was updated, so i can restart my phone, because i know the module will be properly loaded next time

Actual Result

Xposed Installer doesn't send a notification about the module update. Important: it's not happening every time

Other Info

Sometimes it's enough if i launch the Xposed Installer, or force close and then launch it, and then i try to install the module again (but this is not working every time - maybe it only did work when i changed something in AS and the package really got updated again). It seems if Xposed Installer wouldn't get the broadcast received. I had a look in the sources and I've seen that the receiver is not exported, why it isn't? I read that it should be exported because it listens on broadcasts that are sent from outside of the app, but it's weird that sometimes it still gets the broadcast.

"Half OFF": in the future if I'll have the time I will try to improve this part of the notifications a bit. I have ideas on what would i change, and i think i could make the changes. What I'm not sure about is can I send pull requests to this repo? If yes, what branch should i use as the target of the pull request?