Fixed multiple insidious bugs - Githubissues

DVLab-NTU / qsyn

A C++-based growing software system for synthesizing, optimizing, and verifying quantum circuits

Apache License 2.0

168 stars 15 forks source link

Fixed multiple insidious bugs #109

Closed JoshuaLau0220 closed 8 months ago

JoshuaLau0220 commented 8 months ago

Check List

[x] Does your submission pass tests by running make test?
[x] If you have specified a [no ci] tag, does your submission also pass tests by running make test-docker?
[x] Have you linted your code locally with make lint before submission?

Added

-

Changed

MacOS tests now also checks if the tests are consistent

Fixed

Fixed ZYZ decomposition fails on some devices due to floating point errors
Fixed Duostra shortest-path router causes segfault (#62)
The following behavior discrepancies between MacOS and Ubuntu have been rectified:
- gadget fusion ZX-rule does not keep the same gadget
- extractor might put swap gates in different orders
- optimizer might build circuits starting on different qubits
- duostra might select different physical qubits if some of them have the same cost
github action passing even if some tests has failed

Removed