search

DVLab-NTU / qsyn

A C++-based growing software system for synthesizing, optimizing, and verifying quantum circuits
Apache License 2.0
166 stars 15 forks source link

Dynamic Extraction #137

Closed chinyi0523 closed 4 weeks ago

chinyi0523 commented 1 month ago

Check List

  1. [ ] Does your submission pass tests by running make test?
  2. [ ] If you have specified a [no ci] tag, does your submission also pass tests by running make test-docker?
  3. [ ] Have you linted your code locally with make lint before submission?

Added

Changed

-

Fixed

-

Removed

-

JoshuaLau0220 commented 1 month ago

The Ubuntu tests failed because apt update was missing before apt install in the docker scripts. I'm not sure why it was not a problem before, but I've fixed it now.

What's remaining seems to be the test tests/conversion/zx2qc/extractStep.dof not passing. This was because the compiler implicitly cast the nullptr to false in the constructor of Extractor, so the extractor is not extracting to the focused QCir. I've swapped the param for QCir and the random flag to avoid this bad casting from happening.