DWM86 / transcoding-machine

Automatically exported from code.google.com/p/transcoding-machine
0 stars 0 forks source link

How do I join this project to help contribute? #9

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
I'd like to join the project and help contribute code.  I re-wrote the user 
interface using BWToolkit which I thought made the app look a bit more 
polished.  Not sure if you are even interested in it, but if you are, I'd like 
to check it in.  Otherwise, I'd like to contribute to the app.

Here is a screenshot.

Original issue reported on code.google.com by joshkerr on 12 Jul 2010 at 8:33

Attachments:

GoogleCodeExporter commented 8 years ago
Easiest way to get started is to provide a patch

Original comment by cory.powers@gmail.com on 12 Jul 2010 at 9:21

GoogleCodeExporter commented 8 years ago
How can I submit a patch without access?  Don't I need SVN permissions to 
submit a patch?

Original comment by joshkerr on 12 Jul 2010 at 9:55

GoogleCodeExporter commented 8 years ago
The files are publicly available in subversion from this site. You just need to 
make your changes locally and use the subversion tools to generate a patch file 
then attach it and any required resource files to a bug describing what the 
change does.

Original comment by cory.powers@gmail.com on 12 Jul 2010 at 9:57

GoogleCodeExporter commented 8 years ago
I'm not saying this is what I'd submit to the mainline, but here is my patch 
for the visual changes.  

Original comment by joshkerr on 12 Jul 2010 at 10:03

Attachments:

GoogleCodeExporter commented 8 years ago
What did you think?  Can I start contributing?

Original comment by joshkerr on 21 Jul 2010 at 10:11

GoogleCodeExporter commented 8 years ago
The UI is certainly an improvement but that would be a tall task for a new 
contributor, instead there are some smaller issues that would be much easier to 
implement as a new contributor so that we can ensure that the coding style and 
ability is where it needs to be.

Here are a few of the things that I know need to be done, let me know if you 
want to try and tackle one of them.

Put metadata download in separate thread
Move metadata writing to separate thread
Add files to itunes
Automatically unrar .rar files and add resulting videos to queue
Enhance metadata progress bar so it provides a visual representation of  
progress
Add options to map a show name from the file to another show name, e.g. Hell's 
Kitchen US -> Hell's Kitchen
Move metadata writing into its own queue where files could be added directly to 
skip transcoding

Original comment by cory.powers@gmail.com on 22 Jul 2010 at 8:42

GoogleCodeExporter commented 8 years ago
Those are great ideas, cory. I was just thinking about digging into the "add to 
itunes".  I started to do it on my end with hazel, but figured it might be more 
fun to get my hands dirty.  Is anyone working on that?  

The unrar idea is very cool too, as are the threading ideas.

This app is outstanding!  Great job!

Original comment by iamnosk...@gmail.com on 4 Oct 2010 at 5:42

GoogleCodeExporter commented 8 years ago
@iamnoskcaj:
Not to derail this thread, but you can explain how you setup hazel to add the 
file to itunes?  How does Hazel know when the file is finished 
encoding/tagging?  Did you also create a rule to delete the original file?

Original comment by jyoun...@gmail.com on 4 Oct 2010 at 1:36

GoogleCodeExporter commented 8 years ago
No one is working on the 'adding to itunes' stuff at this point feel free to 
take a stab at it. You can take a look at the way we interact with the system 
for managing folder actions, the itunes interaction will take a similar 
approach.

Original comment by cory.powers@gmail.com on 5 Oct 2010 at 7:17

GoogleCodeExporter commented 8 years ago
@iamnoskcaj:

I for one am pushing for an "Add to iTunes" feature. I think it could be as 
simple as calling a script that moves the completed file to the existing 
"Automatically Add to iTunes" folder in the iTunes library directory.

I also like the new GUI that the OP did.

Original comment by ag...@mac.com on 5 Oct 2010 at 7:31

GoogleCodeExporter commented 8 years ago
Take a look at "breakfast" which is the project transcoding machine is based 
on. It had automatic adding to iTunes.

Original comment by ag...@mac.com on 7 Oct 2010 at 11:55

GoogleCodeExporter commented 8 years ago
whoops, I mean "videoengine"

Original comment by ag...@mac.com on 7 Oct 2010 at 11:55

GoogleCodeExporter commented 8 years ago
A simple solution is to set transcoding-engine's output directory to be your 
"Automatically Add to iTunes" folder in the iTunes directory.  Then when 
transcoding-engine is done with all it's batches, if you open iTunes, they all 
get added to iTunes automatically.  Or an alternative is to setup Hazel to 
watch open the files in the folder.  Since they're already in the iTunes tree, 
when they're added they're just moved and added to the library, avoiding the 
problem of leaving a copy of the transcoded file behind.

The problem I'm coming up against (while trying to do this without any 
programming) is that if I open iTunes (or something triggers iTunes to open) 
while files are still being transcoded, it will try to add the file that's 
being actively transcoded... and it seems to be interrupting the flow of 
transcoding-machine.  When this happens, I've noticed that the file gets 
transcoded properly, but then it doesn't get tagged... and every subsequent 
file doesn't get tagged either.  I realize this sounds hokey... so I'll try 
running a test to reproduce it, and share the relevant log entries.

Thanks!

Original comment by iamnosk...@gmail.com on 25 Oct 2010 at 12:51

GoogleCodeExporter commented 8 years ago
Sorry for posting back-to-back... but I was thinking about this issue, and I 
think a simple solution to the problem of not knowing when the transcode/tag is 
complete is as follows:

If transcoding-machine used a temporary file extension while the transcoding 
and tagging process runs, like "movie-file.m4p.tmp" and when it's completed, it 
removed the trailing ".tmp", then it would be a trivial task to watch for 
completed files (for a user to automatically add to iTunes, or any other 
system, without having to add a feature to the app)

Original comment by iamnosk...@gmail.com on 25 Oct 2010 at 12:54

GoogleCodeExporter commented 8 years ago
Hi everyone, I am using a folder action on the TM output folder.  Whenever it 
sees new files it sends them over to 'auto add to itunes' directory. 

Original comment by bjs...@gmail.com on 14 Dec 2010 at 3:00