search

DWilliames / google-sheets-sync-figma

82 stars 8 forks source link

Only first row of data is applied when syncing to nested components #114

Open maracht opened 2 years ago

maracht commented 2 years ago

Describe the bug Only the first row data is applied when using Google Sheets Sync on nested components. image image image

To Reproduce Run sync on the component Figma file: https://www.figma.com/file/6Mv5HAu1kPMlq3bgMgfmHI/For-Github-Big-report?node-id=0%3A1 Google sheet: https://docs.google.com/spreadsheets/d/1xLfR8WaTFky3RoUogJDMI2Flr_flbCRAwYbb8JNbNhw/edit?usp=sharing

Expected behavior All data should be applied, instead of just the first row of the data image

r-carlander commented 2 years ago

Hello, If you name your layers "#article_image.1", "#article_image.2", "#article_image.3" etc, it will work. Not a perfect solution, but it works. Screenshot 2022-06-08 at 09 18 22

maracht commented 2 years ago

@r-carlander Thanks for the workaround. I'll try this in the meanwhile.

In my opinion, naming layers is not ideal as it takes some time.

On the other hand, if this is a bug, fixing it will save people a lot of time :)

r-carlander commented 2 years ago

@maracht I agree! But it seems like @DWilliames is very busy, he doesn't check in here very often. So the workaround is better than nothing I guess 😅

jonleung commented 1 year ago

Thanks @r-carlander this worked for me, appreciate the heads up on this!

I do agree with @maracht that it would be ideal for this to work with Nested components as well.

Thanks to you both, and especially to @DWilliames for creating this! Would love to have this functionality @DWilliames : )

jonleung commented 1 year ago

This was helpful though to work with @r-carlander's solution: https://help.figma.com/hc/en-us/articles/360039958934-Rename-Layers and then using "Shift + Cmd" Click to click directly on the sub component.