search

DWilliames / google-sheets-sync-figma

80 stars 8 forks source link

When Syncing a column of %, Data of first row influences the opacity of the layer group on destination figma file. #163

Open acrypt0 opened 1 year ago

acrypt0 commented 1 year ago

Describe the bug When Syncing a column of data that looked like +X,XX% and -X,XX%, it looks like the plugin applied the value of the first column data to the opacity of the column group on Figma. As a designer it's not the end of the world, I need to select the freshly synced column in figma and press "0" to reset opacity to 100%. But for non-designer crowd, it might look like the column disappeared when synced (when actually, opacity just went to like +0,58% or something like that.

To Reproduce Easy to reproduce every time. Can't possibly record screen or add screenshot sorry.

Edit: If I duplicate my destination figma template to 1 or X copies, and when syncing them together, the issue of opacity influence between Google Sheet and Figma will only affect the original figma template (as in the earliest figma timestamp version as they are all similar). Like if I delete the oldest version (original) the first duplicata of it then becomes the oldest frame and will take the issue on the next Sync.

Screencapture Error Dialogue

Expected behavior The plugin should NOT let the value of the first row of the column in google sheet influence the figma file column opacity

Additional context There were conditional format rules on the google spreadsheet, to make the -X,XX% look red, and the +X,XX% green, but even after deleting these, and all the google sheet data being the default black, the problem persists.

acrypt0 commented 1 year ago

Edit 2 Removing the "#Name_of_column%" from the name of group containing the "#Name_of_column%.1, .2 etc.." fixed the issue.