search

DWilliames / google-sheets-sync-figma

80 stars 8 forks source link

Repeating layers does not work with Components #195

Closed tinabeans closed 9 months ago

tinabeans commented 9 months ago

Describe the bug When following these instructions to have the plugin automatically repeat layers for each row in the spreadsheet, I find that I'm unable to do so if the Figma object that is being repeated is a Component (as in the source component, not a derivative instance). What happens is the component gets repeated, but with the same content all from the first row of the spreadsheet.

To Reproduce Video: https://drive.google.com/file/d/1i2Nl_VQqLHfJYxyKbnb_cFc_qswPnH34/view?usp=sharing Google sheet: https://docs.google.com/spreadsheets/d/1hQUteIC7rPAw5dDx-dPmZD6nCEE_P-lLGWB_GNcQZKE/edit#gid=0 Figma: https://www.figma.com/file/9qWL1Pa3DEHwbnczwyCDe5/testing-Google-CSV-import?type=design&node-id=0%3A1&mode=design&t=6q2JUuPhqlXZ1nS8-1

Expected behavior Both the instance-based objects and the Components are duplicated with the correct content.

Additional context It's entirely possible I set something up wrong; if so please correct me and ignore this bug report!

tinabeans commented 9 months ago

This was a dupe of https://github.com/DWilliames/google-sheets-sync-figma/issues/152 and the issue can be fixed by adding a "+" to the main component.