Data doesn't update when using nested components

neodoubleo commented 3 years ago

Describe the bug Awesome plugin. But I ran into something that completely ruins it for me: Data doesn't update when using nested components.

To Reproduce

Create a component with text and image layers, all named according to the plugin documentation.
Create 3 instances of that component and group them. Name the group //grid (assuming the google sheet is named "grid")
Run the plugin on the group. Data gets fetched, all three instances of the component are updated nicely.
NOW: Convert the group into another component.
Run the plugin again.
Data doesn't sync in the nested components. If you create instances of this new component, none of them sync.
As soon as I drag the group out of the component, things work fine again. Obviously, the issue is with the nesting.

Expected behavior

Data should update in components that are nested under other components.

Additional context This is very important for all the work I do. I usually create screens with components on them. Then turn those screens into components so that I can create a bunch of screen states using instances of the master screen. (this workflow is similar to converting artboards to symbols in Sketch) google-sync-bug.fig.zip

elliotbirchoptus commented 3 years ago

I am having a similar issue. I wasn't sure if it was related to the use of Variants though. It seems more likely that it's Nested Components that cause the issue.

georgehiley commented 3 years ago

Just adding a comment in case this helps, as far as I am aware the use of nested components works fine.

I have noted in the documentation however that Master Components (opposed to instances) will NOT work... there is an override if you want to update a Master Component, otherwise the tool ignores them. I can see you have commented that your parent group Component was an Instance, so if that is correct then this is probably not relevant, however I then note that I do not have any issues with components that are nested within other components, so long as all layers are named they seem to sync without a problem.

jamesgrubb commented 1 year ago

Hi @georgehiley you mention an override to update a Master Component. Could you explain, please? My issue is if I run the plugin on a frame called @# Group with auto layout applied and which contains a nested instance it works. If I convert the frame to a component it stops working. Any thoughts? Many thanks.

jamesgrubb commented 1 year ago

Hi i found the override in a comment in this issue, basically prepend the layer name with '+'

jonleung commented 1 year ago

So I am also running into the issue with Nested components.

It doesn't seem related to the Master component stuff because if I set the Master component to have a "+", it actually things work as expected inside the Master component but NOT the children of the Master component.

DWilliames / google-sheets-sync-figma

Data doesn't update when using nested components #53