search

DWilliames / paddy-sketch-plugin

Automated padding, spacing and alignment for your Sketch layers
MIT License
2.17k stars 61 forks source link

Paddy randomly works with Sketch 49.3 #100

Open stigmates opened 6 years ago

stigmates commented 6 years ago

Bug report

Expected behavior: buttons correctly resize regarding textes length

Actual behavior:

Nothing happens when I overide/change text label, in a group or in a symbol. But sometimes it works. It's driving me nuts. I uninsgalled and reboot, tried paddy in different sketch files (new or work in progress doc), no clue of what could it be responsible…

Steps to reproduce: random! sorry…

blynkkk commented 6 years ago

Same here. Old symbols don't work. When creating new group with "paddied" layer - works

stigmates commented 6 years ago

For me it seems not to be a matter of old or new created symbol. This afternoon I duplicated a button previously created and changed the label. It perfectly worked. But half an hour I did exactly the same with the same original symbol to show someone, and it failed! weird…

ziyafenn commented 6 years ago

Nothing works

Joshuasony commented 6 years ago

Same here. Sometimes it works, most times it doesn't. I have not found out if it is because of my symbols or because of Plugin incompatibility or because of my Sketchapp Version. Would be nice to have more information about those issues. Since Paddy Plugin is released, I'm testing it regularly again and again, without ever having a really functioning version. This plugin has so much potential, it would be really awesome if it worked. I also contacted DWilliames on Twitter DM and Mail, but never recieved an answer. I'd totally be ready to help out in this matter, but nobody is reacting on those issues. Maybe here on Github? Any updates from the others? Have you tried temporarily disabling all plugins?

chsWeb commented 6 years ago

Does anyone have special characters or numbers in any of their file names - either in layer names or parent folders?

stigmates commented 6 years ago

Nope

Joshuasony commented 6 years ago

@chsWeb, yes, I'm using emojis in page names. Is that the problem?

chsWeb commented 6 years ago

@joshuasony I am not sure if the special characters are to blame, but I seem to have this problem most when using special characters any where near a Paddy layer.

chsWeb commented 6 years ago

Almost seems like a delay. When it stops working for me, I click off of the Paddy layer, do something else, then come back, click the Paddy layer, then press escape and Paddy kicks in.

DWilliames commented 6 years ago

Hey all!! Sorry for the delay – my email has been playing up; and everything automatically went to Spam; so I accidentally missed a lot of emails and updates about these issues.

It seems like the way I initially implemented the 'auto-updating' has become quite flaky with newer Sketch versions. I don't think there's too much I could do to fix it in the current way it is implemented.

In saying that; I began the endeavour of completely re-writing Paddy... and let me tell you; it is a lot faster; and way more reliable so far. (In a recent benchmark test, the newer implementation was no joke, 200x faster!!)

Please bare with me; as I try and reach feature parity with the re-write. I will try and release some sort of Beta of 'Paddy 2' in the next week for you all to test out. Which will hopefully solve all these issues.

Thanks for your patience! 👍

johanneslamers commented 6 years ago

@DWilliames 🙌🙏

chsWeb commented 6 years ago

Sounds great. JFYI, I think you should post a way for us to send you some donations. I’d gladly contribute to your efforts. Paddy has real potential.

johanneslamers commented 6 years ago

@chsWeb you already can make a donation. Check the README.

If you love this plugin, why not shout me a coffee ☕️ via PayPal to share the love! It will definitely help me to be able to support this plugin further.

DWilliames commented 6 years ago

Hey all!

Quick update on this: I've released an early preview of the beta now. See #110 or https://github.com/DWilliames/paddy2-beta if you'd like to try it out. 🎉

Doesn't do everything yet... but I'd be keen to find out if it is more reliable for everyone so far. 🤞

marysea commented 6 years ago

Yep – having a similar issue – including when using an icon in a button, when you override the type the whole button shifts to the left and the gap between the icon and the text expands – I've tried all kinds of things and it's just behaving randomly. As others have noted, I quit sketch re-opened and it works for the first override and then goes crazy again. It does the same thing with a button without an icon – again ramdomly. Looking forward to an update… it's such a life saver! t