Crashing while editing text in Sketch 51

DWilliames / paddy-sketch-plugin

Automated padding, spacing and alignment for your Sketch layers

MIT License

2.17k stars 61 forks source link

Crashing while editing text in Sketch 51 #124

Open humso opened 6 years ago

humso commented 6 years ago

Bug report

Is crashing all the time in the latest version of sketch (51)

JesseBilsten commented 6 years ago

I'm also getting this intermittently.

murillovp commented 6 years ago

Same here, commenting for visibility.

juergengenser commented 6 years ago

same here. Sketch is often quitting unexpectedly when applying some changes to Paddy-based elements. super annoying when working on larger projects.

JesseBilsten commented 6 years ago

I've been working on identifying the conflicts to see if it's due to another plugin conflict.

That said, I've limited my plugins to the following and so far have not had it crash yet:

On Fri, Jul 20, 2018 at 1:42 AM, Jürgen Genser notifications@github.com wrote:

same here. Sketch is often quitting unexpectedly when applying some changes to Paddy-based elements. super annoying when working on larger projects.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/DWilliames/paddy-sketch-plugin/issues/124#issuecomment-406531544, or mute the thread https://github.com/notifications/unsubscribe-auth/AAqt4tWEJgLoDigmKDdWYXJuTd6I7Uhoks5uIZfkgaJpZM4VS7zy .

erin-dot-io commented 6 years ago

Possible temporary fix: Disabling automatic updating seems to prevent the crashing, and layers will still update/reposition when you finish editing the content of text objects.

JesseBilsten commented 6 years ago

This has happened exclusively for me when I hit ⌘ + Enter on a textLayer. Anyone else experiencing it on another event?

murillovp commented 6 years ago

@JesseBilsten I had to turn off automatic updating, but it was happening with no pattern behavior. I'm using the workaround @erindotio suggested, it works partially as button symbols are not resizing after changing the text instance, only when you edit the text directly on the group object.

DWilliames commented 6 years ago

Thanks all. I can't seem to reproduce this. Next time it happens are you able to copy the crash log and paste it here? It will definitely help me be able to debug this.

Sorry for the delay. I've been focusing on Paddy 2; which will hopefully fix all this anyway.

murillovp commented 6 years ago

Sure @DWilliames ! The latest Sketch 51.2 update seems to fixed the issue though, I have had not a single crash yet. Paddy is currently a fundamental part of my design system, I hope you keep supporting it till skynet break us apart.

humso commented 6 years ago

It still keeps on crashing Sketch 51.2 while using only the paddy plugin. I'm sharing the crash as requested by @DWilliames Crash_Paddy_Humso.txt

wouter-leistra commented 6 years ago

For me it crashes very often still especially with right clicking on symbols after updating a symbol that is in a group that has paddy declaration on it to space them out.

scottwilliams58 commented 5 years ago

Still having this issue. Will try and share a log.

justinpocta commented 5 years ago

Just found this thread. Been dealing with several daily crashes, usually while editing text, but Paddy is my life so I'm pushing through. :) Here's a link to my latest crash report in case it is helpful at all! @DWilliames (watching Paddy 2 via Twitter and pretty into what I'm seeing there!)

Thank you!

VMSDesigns commented 5 years ago

It's solved for me

In my case, the crash happens only if the paddy values are applied directly to the artboard. I had previously applied [100v c] directly to the artboard and sketch was crashing while editing text.

Now, I put everything in a group and applied the values to that group and no more crashes.

JesseBilsten commented 5 years ago

I get the hard crash almost exclusively now when I hit cmd + enter on a textLayer that calls up the chain to a Paddy element.