search

DWilliames / paddy-sketch-plugin

Automated padding, spacing and alignment for your Sketch layers
MIT License
2.17k stars 61 forks source link

[Bug report] Descender impacts padding on text layers #128

Open raphaelloder opened 6 years ago

raphaelloder commented 6 years ago

Bug report

Expected behavior:

When padding is dependent on text layers on a vertical axis (such as a symbol with only text layer and a rectangle with "[0 x]"), the height of the symbol should stay flexible depending on the line-height of the text layer, but independent of the actual content of the text override.

Actual behavior:

The height of the symbol changes depending on if the override text contains letters that have descenders. Only if a descender is present in the override, the height is calculated correctly (irregardless if the original placeholder contains a descender or not). This is also affecting multiple lines. If the last line doesn't have a descender it's wrong again.

Steps to reproduce:

screenshot 2018-08-01 15 14 14

descender-paddy-bug.sketch.zip

fancymans commented 6 years ago

I have the same issue described here with descenders. I figured I would give Paddy2 Beta a shot and the problem seems to be fixed. However, it also seems like ignoring padding doesn't work in Paddy2 at this point.

blaskotron commented 5 years ago

I think this may be fixed. As soon as I open your file and click the symbol text and click away, all the instance heights update to match. i.e. 40 40, 80 80 80, 120 120 screen shot 2018-09-05 at 8 26 27 am

raphaelloder commented 5 years ago

Are you using Paddy 2? Because there hasn't been an update in a few months for Paddy.

blaskotron commented 5 years ago

Ah you're right. I was looking at wrong github.

I was assuming every one moved on from 1.