search

DWilliames / paddy-sketch-plugin

Automated padding, spacing and alignment for your Sketch layers
MIT License
2.17k stars 61 forks source link

[Bug] Paddy doesn't work with symbol #39

Closed amitdud closed 6 years ago

amitdud commented 6 years ago

When i create a symbol from the group the padding not working when i override the text

surajnaikin123 commented 6 years ago

I too observed this, they way it started working with a symbol is something like this. I created a symbol, let's say with your initial text 'Normal Button' - first override it with a smaller text say 'Button' in an instance, it works. Then again override it with bigger text 'A Bigger Button', it starts to work.

cjcheshire commented 6 years ago

I thought I had this issue. But I hadn't updated the resizing rules for the text layer so it looked like this:

image

Ensure it is like this:

image

dannylodesigns commented 6 years ago

+1 having same issue.

blaskotron commented 6 years ago

Same, not working consistently.

DWilliames commented 6 years ago

Hey all – are you able to provide a bit more details if possible for what exactly is not working. Is it just that it is not resizing automatically consistently? Or is it that it is resizing to the wrong size? If so, please provide a screenshot or screen recording to help.

Cheers.

blaskotron commented 6 years ago

Symbol instance size doesn't update when text is overridden. Sometimes it will randomly. I've used a demo file that came from another post. But also created by own here in the zip.

Sketch version 48.2

screen shot 2018-02-24 at 12 16 31 pm

Paddy Issue.sketch.zip

DWilliames commented 6 years ago

I just pushed a release (v1.0.4) that should now fix this. 👍

I will close this issue for now, assuming that the fix is stable — if you find that it hasn't been fixed, then please re-open this issue.

Cheers!

amitdud commented 6 years ago

Thank you David! It's working perfectly now 💪

Weissenberger13 commented 6 years ago

Hey, ive been having this issue as well. It was working perfectly and has now stopped altogether whenever I override the text.

Any ideas?

Thanks

bazzle commented 5 years ago

Still doesn't work for me, in that paddy symbol inside another symbol doesn't resize when I override text

paddy symbol on it's own = works paddy symbol inside other symbol = doesn't work

When I detach the paddy symbol it suddenly works.

mooona commented 5 years ago

still not working, with symbols: when I create symbol and try to hide stuff from it or make text bigger it's not working, however, it works fine inside the symbol page but when I try to use it as dynamic symbol it doesn't work :(