search

DWilliames / paddy-sketch-plugin

Automated padding, spacing and alignment for your Sketch layers
MIT License
2.17k stars 61 forks source link

[Bug] Using [x] parameter impacting symbol size #54

Open lostsatellites opened 6 years ago

lostsatellites commented 6 years ago

Bug report

Expected behavior:

The x parameter should not impact the padding for edges it is not applied to.

Actual behavior:

Using the x to ignore padding on certain edges is causing other padding to not work. For example, I have a button with padding [10 x 11] for a button with a 40px height on the symbol page. When using the symbol in layout the height changes to 37px. Using an integer instead of x maintains the button height at 40px. I have also tried [10 x 11 x] and the same height change happens. You can see in the screenshots that the button appears to be getting cropped on the lower portion.

screen shot 2018-02-28 at 12 19 56 pm screen shot 2018-02-28 at 12 20 25 pm

Steps to reproduce:

See above. (Tried to attach Sketch file, but got a "We don't support that file type." error message.

mikeozornin commented 6 years ago

(Tried to attach Sketch file, but got a "We don't support that file type." error message.

You can make a zip from sketch file and attach it.

DWilliames commented 6 years ago

Yeah that seems quite weird @lostsatellites. Thanks for reaching out.

I think Paddy is struggling with Symbol support at the moment; I'm going to have to re-think my approach for how it is implemented. 🤔