search

DWilliames / paddy-sketch-plugin

Automated padding, spacing and alignment for your Sketch layers
MIT License
2.17k stars 61 forks source link

[Bug] Update upon children deletion #73

Open jackiecorn opened 6 years ago

jackiecorn commented 6 years ago

Feature request / enhancement

Today layers in a group only update when their frames or positions change. However, I ran into a case where I had a group of items: options

When I removed one of the items, I expected the group to update automatically but it didn't: options2

I had to intentionally move something by a pixel to make it refresh. Can you please add the ability to update layers in a group upon deletion, or may be upon any change in the number of children? (Right now only increase in children number will trigger an update)

Thanks!

DWilliames commented 6 years ago

Thanks @jackiecorn! I actually added a bunch of code a while ago to handle the case of deleting. So it should work. 🤔

In a basic scenario it seems to be working for me... http://dw.md/GDlCP

Can you provide a screenshot of your layer list perhaps? That may help figure out why it's not working for you.

DWilliames commented 6 years ago

I've changed this from an 'Enhancement' to a 'Bug' since the behaviour is already intended to be there. It just doesn't seem to be working for you.

jackiecorn commented 6 years ago

https://www.dropbox.com/s/286p047rca0ya2j/paddy%20bug.mov?dl=0 I did the same thing as your video shown, but it still didn't work. BTW I'm on sketch 48.2 not 49 if that matters.

DWilliames commented 6 years ago

Hmmm, weird 🤔

Thanks; I might have to look into this further.