search

DWilliames / paddy-sketch-plugin

Automated padding, spacing and alignment for your Sketch layers
MIT License
2.17k stars 61 forks source link

Automatic updating doesn't work for me (Sketch 49.2) #98

Open eliran-ran opened 6 years ago

eliran-ran commented 6 years ago

Bug report

Expected behavior:

I have a badge with 8px padding (Text + shape layer grouped together). The background layer is named "background [8]". When changing the text, I would expect the background shape to automatically resize. "Automatic updating" is turned on. I'm using Sketch 49.2

Actual behavior:

The background shape will resize only if I run the command "Enter padding for selection" again and again. I wonder what happened to the amazing "Automatic updating" feature?

kium-one commented 6 years ago

Maybe the same issue for me, Paddy "stops" working sometimes. Here's what the console says : Error in command main Script at path /Users/xxxxxxxxx/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Paddy.sketchplugin/Contents/Sketch/main.js does not contain a handler function named: selectionChanged.

Raghav789 commented 6 years ago

I think every time a sketch update happens plugin starts to misbehave, fresh installation worked for me 1.un-install the plugin and quit sketch(not just close you need to quit it) 2.Reinstall the plugin

DWilliames commented 6 years ago

Yeah I think there's a weird issue within Sketch. Because there definitely is a handler called selectionChanged @najiglass. In the couple of cases I came across it, I just restarted Sketch and re-installed the plugin and it worked. It seems to be an issue with how Sketch caches the plugin I think. 🤔 No too sure. But I don't think there's much I can do.

@eliran-ran The 'automatic updating' feature should definitely still exist.

Either way – just an FYI, I'm in the process of completely re-writing Paddy; which hopefully should take care of a lot of these issues; plus in my first couple of benchmarks the new version seems to be around 30x faster 🔥

Bare with me as I try and bring the new version up to parity, and I promise it will be heaps better. Thanks for your patience all!

kium-one commented 6 years ago

Wow that’s incredible news. Thanks for doing this. Hope you could manage nested symbols as well at some point so I could get rid of Auto-layout (which is so slow) :)

On Apr 6, 2018, at 7:52 PM, David Williames notifications@github.com wrote:

Yeah I think there's a weird issue within Sketch. Because there definitely is a handler called selectionChanged @najiglass. In the couple of cases I came across it, I just restarted Sketch and re-installed the plugin and it worked. It seems to be an issue with how Sketch caches the plugin I think. 🤔 No too sure. But I don't think there's much I can do.

@eliran-ran The 'automatic updating' feature should definitely still exist.

Either way – just an FYI, I'm in the process of completely re-writing Paddy; which hopefully should take care of a lot of these issues; plus in my first couple of benchmarks the new version seems to be around 30x faster 🔥

Bare with me as I try and bring the new version up to parity, and I promise it will be heaps better. Thanks for your patience all!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

tschmeisser commented 6 years ago

Awesome news @DWilliames. Thanks for the hard work! On Sat, Apr 7, 2018 at 6:54 AM najiglass notifications@github.com wrote:

Wow that’s incredible news. Thanks for doing this. Hope you could manage nested symbols as well at some point so I could get rid of Auto-layout (which is so slow) :)

On Apr 6, 2018, at 7:52 PM, David Williames notifications@github.com wrote:

Yeah I think there's a weird issue within Sketch. Because there definitely is a handler called selectionChanged @najiglass. In the couple of cases I came across it, I just restarted Sketch and re-installed the plugin and it worked. It seems to be an issue with how Sketch caches the plugin I think. 🤔 No too sure. But I don't think there's much I can do.

@eliran-ran The 'automatic updating' feature should definitely still exist.

Either way – just an FYI, I'm in the process of completely re-writing Paddy; which hopefully should take care of a lot of these issues; plus in my first couple of benchmarks the new version seems to be around 30x faster 🔥

Bare with me as I try and bring the new version up to parity, and I promise it will be heaps better. Thanks for your patience all!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DWilliames/paddy-sketch-plugin/issues/98#issuecomment-379460931, or mute the thread https://github.com/notifications/unsubscribe-auth/AArzZE6HJC6SIgJy3LuDrINJRRd2V7FTks5tmJrtgaJpZM4TG767 .

eliran-ran commented 6 years ago

Awesome news indeed @DWilliames. Thank you for you efforts!

DWilliames commented 6 years ago

@najiglass Thanks 😄 I've begun focusing on nested symbols; and so far I have managed to get it working to some degree. I've got quite a few more kinks to work out. But it's looking promising 👌

Raghav789 commented 6 years ago

@DWilliames it's amazing to hear that you are working on the new plugin but please don't forget your core ideals. I've been working on this huge project for about six months and anima total ruined my spec export.

No special data manipulation: This simply resizes and moves your layers to optimal positions – it doesn't turn your groups into a special 'Stack group' or something; so other people or programs such as Zeplin, can read the Sketch file perfectly fine, without the need for this plugin too.

kium-one commented 6 years ago

I’d say David is a genius and can do better :) In any case it might be worth having an enable/disable nested layers option if we think it might break exports.

Raghav, have you tried with the latest Anima update, they claim to have fixed exports.

On Apr 10, 2018, at 5:54 AM, Raghav notifications@github.com wrote:

@DWilliames https://github.com/DWilliames it's amazing to hear that you are working on new plugin but please don't forget your core ideal. I've been working on this huge project for about six months and anima total ruined my spec export.

No special data manipulation: This simply resizes and moves your layers to optimal positions – it doesn't turn your groups into a special 'Stack group' or something; so other people or programs such as Zeplin, can read the Sketch file perfectly fine, without the need for this plugin too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DWilliames/paddy-sketch-plugin/issues/98#issuecomment-380042790, or mute the thread https://github.com/notifications/unsubscribe-auth/AL_cEsuslX7cwhyHkspxhM5yU1f4qc4Uks5tnIFRgaJpZM4TG767.

Raghav789 commented 6 years ago

@najiglass I've tried but instead of reversing or baking only their 'stacks' groups and collapses, they break all groups, removing shapes with no fill and only shadow(I've got a shadow override as a symbol), removing layer blending properties etc. it's very messy.

DWilliames commented 6 years ago

@Raghav789 @najiglass – Thanks for the input. I should definitely be able to do it in a way that 'Nested symbols' would be completely optional; so you could toggle it on/off; depending on how important it is to the user. So they can make the decision, given the trade-offs. 👍

Raghav789 commented 6 years ago

@DWilliames I know I extremely simplifying here how about an option to flat/bake/the transformation?which just detaches the symbols till the point of transformation of the nested symbol, since I haven't encountered any such errors so far. then the user can revert back and continue.