search

DXHeroes / Pipeliner

Simple MacOS Big Sur widget app for checking pipeline status
https://github.com/DXHeroes/Pipeliner
MIT License
35 stars 8 forks source link

Light and Dark Mode UI handling #23

Open jamie-brannan opened 4 years ago

jamie-brannan commented 4 years ago

Hello! Happy Hacktoberfest 🎃 !

This PR is in response to issue #9.

I was tasked with the following by @Jakub-Vacek ...

  • [x] Color of TextField text, labels and icons should be more contrasting (black).

  • [ ] Text in TextField after saving configuration should disappear.

  • [x] Background color should be white

  • [x] Save button should have label.

Currently my build loads as such:
state dark light
proposed

🙋‍♀️ I need help with :

Before submission please... 🙏 🎃

As a maintainer, please have this PR count in accordance with the latest update, please opt-in by...

Thank you for the opportunity to participate and build things together 🎉

Jakub-Vacek commented 4 years ago

Hi nice job 👍 To your questions: 1) Why do you need to change on UI settings on State change? 2) What do you mean by running an example case on my build? 3) You can set text in textfield in action in Button component.

Also, can you please resolve conflict in Pipeliner/ContentView.swift? 🙂 Thank you 🤩

jamie-brannan commented 4 years ago

Hi @Jakub-Vacek 👋

Why do you need to change on UI settings on State change?

I have the following UI state change with the form – the save button turns completely white (as illustrated in the gif below) 👇

Oct-27-2020 4-21-03 PM

I don't understand because oddly enough, I do not have the same visibility issue in dark mode 🤔 Any ideas?

What do you mean by running an example case on my build?

I mean are there specific case examples of pipelines that you use to save as configurations in order to test the detail view ui?

This is what's slowing me down from :

You can set text in textfield in action in Button component.

I'm not sure what you mean by this? I have set text as the button, would you like me to change where I added the text?

Jakub-Vacek commented 4 years ago

1) Well that is interesting. It looks like bug 🤷 Does order of filling-in the form change render behavior? 2) To test functionality I usually use some private repo. We don't have any specific case examples. 3) You can set projectName,projectId and token somewhere around the line 112 in Pipeliner/ContentView.swift that should clean the TextFields

jamie-brannan commented 4 years ago

Hi @Jakub-Vacek ,

I'll have to double check but it I don't believe so, considering the forms accepted I type anything. In terms of security it may be a good idea to add parameters limiting certain formats in each field.

Noted for the test cases.

And it looks like I'll need to resolve some conflicts again before checking this so I'll find another time when I can carve out time to manage to implement changes 👍

Thank you!