added article on Documentation

DXHeroes / knowledge-base-content

Open-source knowledge base covering topics about developer experience.

https://developerexperience.io

Other

130 stars 70 forks source link

added article on Documentation #288

Closed wilsantow closed 3 years ago

wilsantow commented 4 years ago

Closes #111

If an article related PR

[x] I have checked that my suggestion follows the Contribution guide
[x] I have added which issue this PR closes
[x] I have 0 warnings from Danger.js
[x] If I have added images, they are in /files/ folder

If other PR

[ ] I have added which issue this PR closes

github-actions[bot] commented 4 years ago

	Messages
:book:	See preview of the article at [https://preview.developerexperience.io/](https://preview.developerexperience.io/)

Generated by :no_entry_sign: dangerJS against 24fe2b4b1b2a55e6a43b4529cc59c362a1a7ddb3

wilsantow commented 3 years ago

@ridlees Thanks for taking the time to write comments for separate sections. I'll make the suggested changes and open a PR.

ridlees commented 3 years ago

Hello @wilsantow, you don't need to do a new PR. You can push new commits with changes into this PR :) I did not close it :)

DominikMilaniak commented 3 years ago

Hi again @wilsantow! A few days have passed since our last contact, how is it going so far with the incorporation of suggested changes into the article? Is anything not clear enough or do you need help with something? I am in no way pushing you, you can take as much time as you need 🙂 Just wanted to get in touch to make sure everything is ok 👍

wilsantow commented 3 years ago

Hi @DominikMilaniak, Sorry for taking too much time. I made the requested changes. Go through it and tell if there is anything to change and why the preview deploy fails? I looked through the log but couldn't figure out.

prokopsimek commented 3 years ago

@ridlees merge and create issue pls