search

DXgovernance / davi-monorepo

https://davi-monorepo-davi.vercel.app
8 stars 12 forks source link

feat:integrate bundled simulations #260

Closed yathindrak closed 1 year ago

yathindrak commented 1 year ago

Closes: https://github.com/DXgovernance/davi-monorepo/issues/229, https://github.com/DXgovernance/davi-monorepo/issues/148

Screenshot 2023-03-03 at 23 52 23

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
davi ❌ Failed (Inspect) Mar 7, 2023 at 2:20PM (UTC)
rossneilson commented 1 year ago

Couple of findings, mostly it works amazing! and a lot faster than forks!

We used to highlight failed simulations with red borders, would be nice to get that back Screenshot 2023-03-06 at 18 44 08

Then we don't show the failed message and link on the second action which is the one that failed (failed since we spent all the 1554 wxdai on the first action) Screenshot 2023-03-06 at 18 45 10

Also I think we could slim the tenderly link section down to just one line saying: "Simulation [passed || failed] Tenderly logo"

yathindrak commented 1 year ago

Also I think we could slim the tenderly link section down to just one line saying: "Simulation [passed || failed] Tenderly logo"

Thanks, @rossneilson for pointing out the issues and improvements. By the way, the red border was appearing when I create an action for vesting with DXD. Will follow the same steps and find the reason behind. Might be an issue with the simulation results iteration logic introduced with this pr.

Screenshot 2023-03-06 at 19 12 11

Then slimming the tenderly link section down to just one line will be great to save the space for the simulation results block. Will check this as well.

yathindrak commented 1 year ago

@rossneilson The issue is fixed now and improvement is also done. Great if you could check now. :)

Screenshot 2023-03-06 at 20 59 28
rossneilson commented 1 year ago

@rossneilson The issue is fixed now and improvement is also done. Great if you could check now. :) Screenshot 2023-03-06 at 20 59 28

Looks fantastic! Could we maybe add in the error message from tenderly as well, pretty sure we had that before

Also looks like margin and padding might be a little off here Screenshot 2023-03-07 at 13 05 06

yathindrak commented 1 year ago

Improvements are done and incresed the space between status text and tenderly link

Screenshot 2023-03-07 at 19 47 52
Filipv95 commented 1 year ago

@yathindrak sry for the delay, jsut tested this PR - looks good to me, great job!