DXgovernance / davi-monorepo

https://davi-monorepo-davi.vercel.app
8 stars 12 forks source link

1.5 Scheme selection config clean up #330

Closed rossneilson closed 1 year ago

rossneilson commented 1 year ago

Seems we missed a couple of config options in the scheme page.

Want to add:

Screenshot 2023-03-23 at 15 26 40

To make things fit neater we could remove "Can mint reputation" in favour of the "max rep change" which can be 0 if the former is false.

And lets move some items around so the order of the configs goes:

rulfo71 commented 1 year ago

@rossneilson here you are diferentiating between Quorum and boostedVoteRequiredPercentage aren't they the same?

rulfo71 commented 1 year ago

I'm not sure what you meant by 'All the time configs' but i put all the ones that weren't on the list inside that:

image

atm we have two Quorum because of the question above

@rossneilson let me know what you think!

rossneilson commented 1 year ago

@rossneilson here you are diferentiating between Quorum and boostedVoteRequiredPercentage aren't they the same?

They are different actually, quorum is when nothing is boosted and boostedVoteRequiredPercentage is the quorum when boosted, so usually this would be smaller (in current DXdao there is no quorum for boosted proposals)

I'm not sure what you meant by 'All the time configs'

My bad for being lazy there, was just meaning to group any of the configs measured in seconds, so: