DXgovernance / davi-monorepo

https://davi-monorepo-davi.vercel.app
8 stars 12 forks source link

Localhost network - deleted Discussion behavior #361

Open Filipv95 opened 1 year ago

Filipv95 commented 1 year ago

Description Create proposal from Discussion page, it should appear in Discussions Activity section.

What should happen with proposals when I delete original discussion?

ATM on localhost network. I delete discussion that has multiple Proposals attached to it, discussion dissapears. But, from any proposal page (created from deleted Discussion) you can click Original Discussion that redirects you to deleted Discussion (title and description is loading, I guess because it's deleted). Also, Edit Discussion is available and when I edit title/description the deleted Discussion becomes active again (visible on Governance/All discussions pages).

Steps to Reproduce

  1. Build localhost
  2. Go to Localhost Guild
  3. Click on Automation Discussion
  4. Create Proposal with Transfer action
  5. Click on Automation Discussion
  6. Delete the Automation Discussion
  7. Click on newly create Transfer proposal
  8. Click on Original Discussion button
  9. Click on Edit Discussion button
  10. Make changes to discussion title and description

Expected behavior Not sure what should be expected behavior here, perhaps we can just remove the Original Discussion button from Proposals page, if the discussion is deleted.

Environment

Device Information OS: MacOs Browser GoogleChrome, Brave Device: MacOS Ventura v13.1

Additionaly unformation Proposal created from Discussion is not visible in Activity section on localhost network

Filipv95 commented 1 year ago

Hey @rossneilson not sure how to label this edge-case, but it is very real situation, perhaps you have the idea how this can be handled better?