search

DXgovernance / dxvote

Governance Dapp of DXdao
https://dxvote.eth.limo
GNU Affero General Public License v3.0
28 stars 23 forks source link

Summary of actions in proposal card #805

Closed rossneilson closed 2 years ago

rossneilson commented 2 years ago

One of the last placeholders we have is showing all proposals transferring 150 ETH to Gero, time to fix that. With the action builder mostly complete we can now easily decode proposal actions.

We obviously cant show all of the actions when we can have huge numbers of actions and options for each proposal so we need some logic to prioritise the most important calls. In future we'll have a proper importance ranking but for now the below logic can work to order them.

  1. REP minting is always most important eg Mint 1% REP -> rossdev.eth
  2. ENS contract interaction eg (ENS icon) dxvote.eth
  3. Spending calls (Approval + function call grouped together, same to address) eg 1000 DAI -> Swap
  4. Transfers eg 1000 DAI -> rossdev.eth
  5. Generic calls eg Swap (taken from rich contract function name)

We should ideally show 2-3 actions but would be good to show as many as we can fit, maybe a fixed size that just cuts off after it wont fit?

rossneilson commented 2 years ago

We should also have another layer of ordering ontop of the ones described above which shows proposal actions winning and past quorum first as these are most relevant