search

DYefremov / DemonEditor

Enigma2 channel and satellite list editor for GNU/Linux and macOS.
https://dyefremov.github.io/DemonEditor
MIT License
120 stars 142 forks source link

ffmpeg misdetection in Boot Logo tool #210

Closed rdamas closed 1 day ago

rdamas commented 1 day ago

Version 3.11.3 Beta MacOS Arm Version installed from Releases dmg.

ffmpeg needs an additional lib that is not packaged in the dmg:

dyld[35865]: Library not loaded: /opt/homebrew/opt/sdl2/lib/libSDL2-2.0.0.dylib
  Referenced from: <C86404EB-DFC9-31A1-8E95-3F036091FC12> /Applications/DemonEditor.app/Contents/Frameworks/ffmpeg
  Reason: tried: '/opt/homebrew/opt/sdl2/lib/libSDL2-2.0.0.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/opt/sdl2/lib/libSDL2-2.0.0.dylib' (no such file), '/opt/homebrew/opt/sdl2/lib/libSDL2-2.0.0.dylib' (no such file)
Abort trap: 6

This error is not detected because ui.BootLogoManager.init only checks for FileNotFoundError. I'd probably also check the output of ffmpeg -version for a plausible response.

DYefremov commented 1 day ago

Yes, I can confirm this. Apparently last PyInstaller version does not collect this library to the package. Needs additional testing.

DYefremov commented 1 day ago

Replaced the binary from here and updated the ARM build. Please test.

rdamas commented 1 day ago

That binary does the job.