search

DZakh / rescript-schema

🧬 The fastest parser in the entire JavaScript ecosystem with a focus on small bundle size and top-notch DX
MIT License
155 stars 7 forks source link

(docs) consider explicitly mentioning email validation incompleteness #83

Closed dearlordylord closed 2 months ago

dearlordylord commented 3 months ago

Several parser libraries include disclaimers about email validation:

https://valibot.dev/api/email/

https://github.com/ianstormtaylor/superstruct?tab=readme-ov-file#why

https://github.com/effect-ts/effect/tree/main/packages/schema#email

https://github.com/jquense/yup?tab=readme-ov-file#stringemailmessage-string--function-schema

I think it's good to have this reminder; I've seen many beginner developers using email regex blindly without realizing pros and cons.

DZakh commented 3 months ago

Copied the regex from Zod 😁

DZakh commented 2 months ago

Done, thank you for the suggestion https://github.com/DZakh/rescript-schema/blob/main/docs/js-usage.md#strings