search

DaCyclops / GDIW

Factorio Mod : GDIW - Gah!DarnItWater! A Factorio mod for those people who keep getting annoyed at water....
MIT License
3 stars 5 forks source link

Fix issue with some recipes not having variants generated #14

Closed ReikaKalseki closed 5 years ago

ReikaKalseki commented 6 years ago

Such as mentioned here, as well as I suspect in this case.

ReikaKalseki commented 6 years ago

There is one thing left undone with this patch, and that is getting GDIW hotkey working; the flipped recipes exist and can be selected normally, but the hotkey mod seems unable to detect them. I have no idea why, though the "ID strings" of things like "GDIW-AR" and "GDIW-BR" it uses to find such recipes might be worth looking into.

DaCyclops commented 6 years ago

Hmm, Yeah, I dont think I actually EVER took into consideration the Normal/Expensive options for recipes....

EDIT: wait, checked the wrong commit

Your code will find all the normal/expensive versions that should be updated, but its still going to need the function updated to update normal/expensive recipes.....

DaCyclops commented 6 years ago

I cant see any major issues right now, but I might add in a little "to be sure" checking of vrn.ingredients and vrn.results just to be sure. I will merge them when I have a moment to double-check the code at home.

ReikaKalseki commented 6 years ago

I have tested it and it works (rocket fuel):

https://i.imgur.com/RehZWi3.jpg

PCbIX commented 5 years ago

Such as mentioned here, as well as I suspect in this case.

Can you pls fix you patched version to work state pls i tried your latest version and recieve: 33.348 Error ModManager.cpp:1024: Failed to load mod "GDIW": GDIW/data-final-fixes.lua:74: bad argument #1 to 'pairs' (table expected, got nil) 33.349 Loading mod core 0.0.0 (data.lua) 33.496 Checksum for core: 2304860305 33.511 Error ModManager.cpp:1024: Error in assignID, recipe-category with name 'crafting' does not exist.

ReikaKalseki commented 5 years ago

Why the hell are you writing that here, which has no bearing on anything you are saying?