search

DaFuqs / AdditionalEntityAttributes

MIT License
6 stars 12 forks source link

[1.20.6] Scale related attributes #25

Closed MerchantPug closed 5 months ago

MerchantPug commented 10 months ago

This'll be a draft until 1.20.5 releases.

Adds these modifiers:

MerchantPug commented 10 months ago

To confirm. Yes, I have talked to Pehkui's dev about this, and I've purposefully made it so we aren't stepping on what makes Pehkui unique going forth.

DaFuqs commented 10 months ago

Oops. Now that looks better.

DaFuqs commented 10 months ago

Love the MOB_DETECTION_RANGE addition!

Now, I am curious, what's the use-case of scaling like height, hitbox_height and model_height individually? Wouldn't it mess with the way the player expects the hitbox size matching the entities size and everything?

MerchantPug commented 10 months ago

Love the MOB_DETECTION_RANGE addition!

Now, I am curious, what's the use-case of scaling like height, hitbox_height and model_height individually? Wouldn't it mess with the way the player expects the hitbox size matching the entities size and everything?

Some examples are: if people have a small entity and you want to make their hitbox slightly bigger to have an easier time hitting them. Or if you want to be slightly taller without a hitbox change that'd screw with going through the what the player would normally be able to go through.

MerchantPug commented 10 months ago

They are absolutely open to misuse, but that's something that any attribute can face. Devs should know what's fair and unfair.

MerchantPug commented 10 months ago

Point is, separate hitbox/model changes work best when subtle. The two points above are imo perfect examples of this. I think that you were thinking of it at a more drastic degree.

Noaaan commented 6 months ago

Bumping this PR as... 1.20.6 already released. :mojank: Would probably be fine for release if the other commits from 1.20.4 are merged/cherry-picked in (d0e9b4d52a200589c8fad9b200095cd412c55d6d ?, 0150a518620aa05034a4ad52746a2a0b05809b4c, and 6f98ceda2e7bf3649c598aba4e813738cd8988dc). Will do some testing once available :+1:

MerchantPug commented 6 months ago

Go ahead.

MerchantPug commented 5 months ago

Okay, I'm nearly done with this PR. Just ironing out some final things.

Some things to keep in mind

DaFuqs commented 5 months ago

Thank you! Have you tested this with vanilla's new generic.scale?

With 1.20.6 we can definitely revamp or remove another attribute or two, since there is now:

DaFuqs commented 5 months ago

I did a bit of cleanup in the current branch. I can fix the conflicts tomorrow.

DaFuqs commented 5 months ago

@MerchantPug I tried mixing vanillas generic.scale and additionalentityattributes.height and the camera weirded out quickly. Can you take another look what would need to be changed to make both compatible? The vanilla camera code may have been revised in general, making the vanilla attribute work with all mobs. Maybe we do not even need all the mixins for individual mobs anymore?

MerchantPug commented 5 months ago

@MerchantPug I tried mixing vanillas generic.scale and additionalentityattributes.height and the camera weirded out quickly. Can you take another look what would need to be changed to make both compatible? The vanilla camera code may have been revised in general, making the vanilla attribute work with all mobs. Maybe we do not even need all the mixins for individual mobs anymore?

Alright, I'll make sure to look into this at some point.

MerchantPug commented 5 months ago

@DaFuqs this has been fixed!

MerchantPug commented 5 months ago

Apologies for being so slow, I've been busy working on another mod.

DaFuqs commented 5 months ago

Thank you lots!