DaFuqs / Spectrum

A full-feature minecraft mod about harnessing the powers of color
Other
102 stars 60 forks source link

[BUG] X-ray Gemstone Lamps #352

Closed ChiefBjorn closed 7 months ago

ChiefBjorn commented 7 months ago

Describe the bug All gemstone lamp variants are see through

Expected behavior Gemstone lamps act like Universe Spyhole should

Mod version Spectrum 1.7.6 AOF 7 - 1.20.1 2024-02-15_22 46 18

DaFuqs commented 7 months ago

Caused by Sodium breaking rendering on translucent stuff.

Try without Sodium or try out their recent nightly, they improved transparency handling by a lot: https://nightly.link/CaffeineMC/sodium-fabric/workflows/build-commit/dev/sodium-artifacts-dev.zip

ChiefBjorn commented 7 months ago

Removing Sodium fixes the issue, thanks!

DaFuqs commented 7 months ago

Np!

Keeping this open until Sodium 0.6.0 is available for MC 1.20.1

eehunter commented 7 months ago

I know this is an issue with Sodium, but wouldn't it be possible to fix it by setting isFullCube() to false or something? Probably not an ideal solution, but I doubt it would impact performance much and it would probably fix the issue.

DaFuqs commented 7 months ago

I've added that in dev (or the most recent release). The lamps rendering is still broken, but at least you can't see through them anymore