DaFuqs / Spectrum

A full-feature minecraft mod about harnessing the powers of color
Other
95 stars 51 forks source link

[BUG] Resonant Shards are only revealed if you've obtained hummingstone, but you can trigger the Hymn using natural generation #395

Closed Robotgiggle closed 1 month ago

Robotgiggle commented 1 month ago

Describe the bug The advancement for triggering the Hummingstone Hymn, which also serves to reveal the Resonance Shards it drops, requires you to have the advancement for collecting hummingstone as a prerequisite. Presumably it's set up this way because the assumption is that you'd need to pick up a bunch of hummingstone and put it together to get enough resonance for the Hymn. However, it's actually possible to trigger the Hymn using only a natural hummingstone formation, and if you do so before ever obtaining hummingstone blocks, the dropped Resonance Shards will be shrouded and unusable.

To Reproduce

Expected behavior It would make a bit more sense if the only criteria for revealing the Resonance Shards was having triggered the Hymn. Removing the prerequisite here doesn't seem like it would allow for any new sequence breaks.

Minecraft version 1.20.1

Mod version 1.7.11

Screenshots image