search

DaFuqs / Spectrum

A full-feature minecraft mod about harnessing the powers of color
Other
104 stars 64 forks source link

Blacklist colored preservation stone from paintbrush recoloring #572

Closed Robotgiggle closed 1 week ago

Robotgiggle commented 2 weeks ago

Currently, colored preservation stone gets caught by the getCursedBlockColorVariant system, and thus it's a valid target to be recolored using a paintbrush. Given that preservation stone is an unbreakable structure component, I don't think it makes much sense for players to be able to just recolor it at will - particularly since it allows you to (intentionally or otherwise) change the color of the "backup" preservation stone above the roundels in mixing ruins.

This PR adds colored preservation stone to the ink_effect_blacklisted tag so it can no longer be recolored. This PR adds a hardness check to getCursedBlockVariant so that it always fails on unbreakable blocks.

DaFuqs commented 1 week ago

Agreed, definitely. I feel we should also hard-exclude all unbreakable blocks by default (checking the hardness in-code). Opinions?

Robotgiggle commented 1 week ago

Hardness check has been implemented. I also removed the colored pres stones from the ink_effects_blacklisted tag since that's redundant now.