search

DaFuqs / StarrySkies

Minecraft "skyblock style" worldgen mod for fabric
GNU Lesser General Public License v3.0
6 stars 3 forks source link

[BUG] End Portal Generates Outside Frame #28

Closed Brittank88 closed 3 years ago

Brittank88 commented 3 years ago

Describe the bug On completing the end portal frame, the portal has... generated outside of it. It's kinda odd to look at.

To Reproduce Just build a portal frame anywhere and fill it out.

Expected behavior Normal end portal spawn behaviour.

Screenshots 2021-11-26_19 36 24

DaFuqs commented 3 years ago

The End portal seems to be build weirdly. Despite not looking like it at first glance, the end portal frames have a direction property that is used to determine where the portal should be located.

2021-12-03_11 55 53 (look at the direction of the eyes - build when standing in the middle and building all frames facing the center)

That said, in such a case vanilla would not generate a portal at all, that is on me. I will change the behavior accordingly.

Brittank88 commented 3 years ago

Very interesting! Thank you for responding so quickly. :)