search

DaGeRe / peass

Tool for Performance analysis of software system
GNU Affero General Public License v3.0
10 stars 9 forks source link

Add external storage read/write permission for Android #117

Closed metint closed 1 year ago

metint commented 1 year ago

Partially fixes https://github.com/jenkinsci/peass-ci-plugin/issues/168

Tests are still missing. @DaGeRe do you have any suggestions for possible test implementation?

DaGeRe commented 1 year ago

Thanks for the PR. I would suggest to just move updateAndroidManifest to ManifestEditor, pass the necessary variables to it and check whether a correct manifest file is created.

metint commented 1 year ago

@DaGeRe, I have just added the unit test. Please let me know if any other action is required.

DaGeRe commented 1 year ago

Thanks for the update! Seems fine to me.