search

DaGeRe / peass

Tool for Performance analysis of software system
GNU Affero General Public License v3.0
10 stars 9 forks source link

Add java compatibility configuration #127

Closed metint closed 1 year ago

metint commented 1 year ago

Partially fixes https://github.com/jenkinsci/peass-ci-plugin/issues/210

metint commented 1 year ago

@DaGeRe I checked the code and I realized that the compatibility related modification is already executed only if isUseAnbox() returns true. So it shouldn't effect the other users.

DaGeRe commented 1 year ago

You're right, than this is fine, I'll merge it.

In general, it would be nice to have more fine-grained methods (currently, methods tend to be a big lengthy). I'll have a quick look at it and refactor it where possible.

DaGeRe commented 1 year ago

To improve the readability, I extracted the GradleBuildfileEditorAnbox: https://github.com/DaGeRe/peass/blob/develop/dependency/src/main/java/de/dagere/peass/execution/gradle/GradleBuildfileEditorAnbox.java Feel free to further improve the structure.

metint commented 1 year ago

Thank you. I will also have a detailed look paying attention to method lengths later.