search

DaGeRe / peass

Tool for Performance analysis of software system
GNU Affero General Public License v3.0
10 stars 9 forks source link

Add strictMode for AnboxTestExecutor #138

Closed alex-iotiq closed 1 year ago

alex-iotiq commented 1 year ago

Implements this https://github.com/DaGeRe/kieker-source-instrumentation-dagere/issues/2 for AnboxTestExecutor.

DaGeRe commented 1 year ago

Thanks for the PR. Does this work for you in the source instrumentation? If yes, I'll publish a new source instrumentation release, and than you can adjust the PR and use the latest source instrumentation. Peass should not rely on Snapshots.

alex-iotiq commented 1 year ago

Does this work for you in the source instrumentation?

Yes it does

alex-iotiq commented 1 year ago

But to build Peass-ci-plugin succesfully with those changes I need to downgrade com.github.javaparser:javaparser-core:3.24.9 version to 3.24.8 inside de.dagere.kieker:kieker-source-instrumentation-library:1.15.16-SNAPSHOT.

Require upper bound dependencies error for com.github.javaparser:javaparser-core:3.24.8 paths to dependency are:
+-de.peass:peass-ci:2.3.5-SNAPSHOT-999999-SNAPSHOT
  +-com.github.javaparser:javaparser-core:3.24.8
and
+-de.peass:peass-ci:2.3.5-SNAPSHOT-999999-SNAPSHOT
  +-de.dagere.peass:dependency:0.3.5-SNAPSHOT
    +-de.dagere.kieker:kieker-source-instrumentation-library:1.15.16-SNAPSHOT
      +-com.github.javaparser:javaparser-core:3.24.9
and
+-de.peass:peass-ci:2.3.5-SNAPSHOT-999999-SNAPSHOT
  +-de.dagere.peass:dependency:0.3.5-SNAPSHOT
    +-de.dagere.kopeme:kopeme-junit5:1.2.1
      +-de.dagere.kopeme:kopeme-core:1.2.1
        +-com.github.javaparser:javaparser-core:3.24.8
DaGeRe commented 1 year ago

I'll publish this tomorrow (hopefully). Downgrading the version in Peass-CI works, another solution is to include com.github.javaparser:javaparser-core:3.24.9 as dependency in Peass-CI directly (the plugin checks for different dependency versions, in order to avoid problems due to dependency updates you are not aware of).

DaGeRe commented 1 year ago

I did the update, should work fine now.