Change fixed_time_eq to avoid undefined behavior

DaGenix / rust-crypto

A (mostly) pure-Rust implementation of various cryptographic algorithms.

Apache License 2.0

1.4k stars 298 forks source link

Change fixed_time_eq to avoid undefined behavior #461

Open jaysonsantos opened 4 years ago

jaysonsantos commented 4 years ago

If both slices have len() == 0, I think that get_unchecked will have undefined behavior. I'd say that this is the type of operation that the gain of not checking the boundaries for the first element does not justify the usage of unsafe there, what do you think?