DaGhostman / vscode-tree-view

VSCode extension that probvides mail symbol overview of the currently opened file
MIT License
29 stars 4 forks source link

[2.7.0] - Functions, arrow funcions and beautifying #109

Open RedSparrowEU opened 5 years ago

RedSparrowEU commented 5 years ago

Hello Dimitar,

Thank You very much for the set/get addition! It works great. I have new gr8 chellenges for You! (and yes, yes, I know You're busy)

Please consider following questions:

1. Function or arrow function as variable should be (maybe optionally) interpreted as normal function:

const myPowFunc = (arg) => { return arg*arg }

const mySqrFunc = function (arg) { return Math.sqrt(arg) }

Currently these functions are to be found in the list of variables.

2. Colors in the Tree (readability)

3. Types

As Javascript doesn't use types as TypeScript, trees for .js files should be without ": any". It will improve readability.

4. Quick Filter

Under the heading "FILE SYMBOL EXPLORER: SYMBOLS", could be placed a quick filter input field, working dynamically while typing. The list of elements can then be shortened by using this filter.

Thats's it for the moment. :) Fingers crossed!

Thanks, Greg

DaGhostman commented 5 years ago

Hello, Greg! Thanks for the feedback and I am really glad that you liked the implementation and that you are contributing ideas (oh boy, quite a challenge :laughing: )

From what I've understood so far 3. should not be that hard to implement actually, I think I can manage to swap out types So I will try to find some time and address this soon.

About 4. to be completely honest I kinda lost track as to what is supported by the VSC api regarding custom trees, but I would guess that since it was added for the explorer it should be made available soon (if not already) so that would maybe take some time I think.

  1. I haven't thought about that and by your feedback it actually makes sense, so :+1:
  2. Now the coloring, well I am not 100% sure that would be doable and would require further/greater investigation and effort. But I would love to hear your thoughts as to how else you consider readability to be improved if the usage of the current code scheme is a no-go?