DaPigGuy / PiggyCrates

A crate plugin for PocketMine-MP supporting unlimited crate types
https://piggydocs.aericio.net/PiggyCrates.html
Apache License 2.0
31 stars 41 forks source link

Roulette causes client to crash on PocketMine-MP 3.14.0. #70

Closed 95CivicSi closed 4 years ago

95CivicSi commented 4 years ago

Please make sure your issue complies with these guidelines:

Link to Crashdump:

Extra Information

PocketMine-MP v 3.14.0 PiggyCrates version 2.0.8 When using the roulette option, players attempt to use their keys and are presented the inventory menu as normal. Once the item has been selected, the player's client is crashed when the inventory window is closed. I'm not sure yet if this is something missing from PocketMine-MP, but it looks to be related to Player::removeWindow()

95CivicSi commented 4 years ago

Related to https://github.com/pmmp/PocketMine-MP/issues/3651

provsalt commented 4 years ago

this is a invmenu issue not a piggycrates issue till the virion is updated, there really isn't any fix for it here

Aericio commented 4 years ago

https://github.com/Muqsit/InvMenu/pull/82#issuecomment-653736043

Seems like we'll have to wait for PMMP to fix.

Muqsit commented 4 years ago

I pushed some preparatory fixes to InvMenu (^3.1.1 for api3, ^3.2.1 for api4) that i've verified with InvCrashFix plugin until PMMP fixes it.