DaPigGuy / PiggyCustomEnchants

An open source custom enchantment plugin for PocketMine-MP
https://piggydocs.aericio.net/PiggyCustomEnchants.html
Apache License 2.0
103 stars 118 forks source link

problem with enchants like glowing and gears etc. #70

Closed timbersquirrel closed 6 years ago

timbersquirrel commented 6 years ago

Please make sure your issue complies with these guidelines:

General

I cant keep enchants active like glowing gears and springs when being hit by a mob or player etc. I am using the latest version of pmmp

Version of PiggyCustomEnchants:

PiggyCustomEnchants version 1.0.5

Steps to Reproduce the Issue

  1. Enchant youre helmet with glowing
  2. Have a player or mob hit you
  3. The night vision wears off instantly and you loose the effects from it untill you re-equip it

    Extra Information

    Please try to get it fixed

AffanStarPure commented 6 years ago

Yes i have same issue when equip Armor With glowing on helmet on Durability work take off effect too when take damage even autorepair too when repair u armor Glowing with Autorepair loose effect too need fix too only on armor duralibity

pranavbhuv commented 6 years ago

what @AffanStarPure

DaPigGuy commented 6 years ago

I can't reproduce this issue.

timbersquirrel commented 6 years ago

I’m using version: PocketMine-MP 1.7dev-406 「[REDACTED]」 implementing API version 3.0.0-ALPHA9 for Minecraft: PE v1.2.0.81 (protocol version 137) i don’t know if you are using a different version

Aericio commented 6 years ago

Can you use the latest version of pmmp? (18 builds have passed, maybe something changed ¯(ツ)/¯) Here's the link to Jenkins: https://jenkins.pmmp.io/job/PocketMine-MP/

timbersquirrel commented 6 years ago

That didn’t fix it but it needs to be fixed

AffanStarPure commented 6 years ago

https://youtu.be/WItkPYPif_I watch my video they bug is not problem version PMMP i show proof @DaPigGuy

DaPigGuy commented 6 years ago

I can't reproduce with the steps given by the issue and your video isn't clear enough.

timbersquirrel commented 6 years ago

What version of pmmp are you using @dapigguy

DaPigGuy commented 6 years ago

Build #435 on Jenkins (latest, as of 11/21/17 16:43 PT)

timbersquirrel commented 6 years ago

I just downloaded that too but mine will remove the effect upon damage :/

DaPigGuy commented 6 years ago

On @AffanStarPure's server to investigate (MCPEPIG)

EDIT: I have been able to reproduce the issue.

timbersquirrel commented 6 years ago

Ok thanks dude

timbersquirrel commented 6 years ago

@dapigguy I just downloaded the recent version of pce Glowing makes the sky flash Also springs is a bit glitchy maybe revert it back to jump boost

DaPigGuy commented 6 years ago

Fixed sky flashing. Please be more specific about whats wrong with springs and create another issue.

timbersquirrel commented 6 years ago

Ok