DaPigGuy / PiggyCustomEnchants

An open source custom enchantment plugin for PocketMine-MP
https://piggydocs.aericio.net/PiggyCustomEnchants.html
Apache License 2.0
103 stars 118 forks source link

Chance #76

Closed isoz closed 4 years ago

isoz commented 6 years ago

You should make the enchants have a chance of activating instead of being instant, it's extremely unbalanced.

Artistic-Waffle commented 6 years ago

yeah that cool to have a rate chance for the enchantment to work. add dust to increase the chance of sucess in config and php

Artistic-Waffle commented 6 years ago

such as sugar or glowstone dust

jrodr10 commented 6 years ago

make this feature disableable as its pointless for a factions server but may not be for a vanilla server or minigames server

ghost commented 6 years ago

Basically add chances for Enchantments that break the item but also have it where it can be disabled with a config option.

TwistedAsylumMC commented 6 years ago

books would come before this request im guessing, but pig has a big to do list so it won't be an update coming soon https://github.com/DaPigGuy/PiggyCustomEnchants/issues/2

pranavbhuv commented 6 years ago

Well, as far as I know priorities are high for books, then implementing /combine. As far balancing, I am starting it as a PR, if you know any OP enchant just comment on the PR

TDMidkwhatisxd commented 6 years ago

Great idea .... Enchants should have 50% chances to activate (by default in config)

pranavbhuv commented 6 years ago

@DaPigGuy would this be added, before I balance, or after?

DaPigGuy commented 6 years ago

This will be worked on by Aericio and I.

TDMidkwhatisxd commented 6 years ago

i added chance on my server , only on effects made by armours (not soulbound etc.. xd)

Artistic-Waffle commented 6 years ago

Cool

On Dec 10, 2017 12:23 PM, "TDMidkwhatisxd" notifications@github.com wrote:

i added chance on my server , only on effects made by armours (not souldbound etc.. xd)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/DaPigGuy/PiggyCustomEnchants/issues/76#issuecomment-350563784, or mute the thread https://github.com/notifications/unsubscribe-auth/AeDeag0AsxQHBMZAT3nb8bFqLfh37fI1ks5s_BOqgaJpZM4QqC3Y .

Benjiboi6578 commented 6 years ago

/combiner and /tinkerer would be nice. I known that will take a while. But I was wondering if implementing xp way of earning books is possible? Like by grinding.

Artistic-Waffle commented 6 years ago

How did you add chance

Aericio commented 6 years ago

@Benjiboi6578 Do you mean grinding for xp and using an enchantment table (sign, gui, whatever) to get the custom enchant, or by chances of dropping from mobs?

TwistedAsylumMC commented 6 years ago

i think chances to activate the enchant

TwistedAsylumMC commented 6 years ago

oh i think for the books idk

DaPigGuy commented 4 years ago

cd3dd22