search

DaPigGuy / PiggyCustomEnchantsShop

A shop plugin for both vanilla enchants & PiggyCustomEnchants
https://piggydocs.aericio.net/PiggyCustomEnchantsShop.html
Apache License 2.0
10 stars 10 forks source link

CE limit #31

Closed minijaham closed 4 years ago

minijaham commented 4 years ago

Description

Duplicate of DaPigGuy/PiggyCustomEnchants#261 , but I wanted to make my point clear. I am currently the owner of a server, which I am currently developing on and I was looking for a custom enchantment plugin because I did not want to code a whole different CE core .-.(great plugin btw, I love it)

I definitely need a feature that which sets a limit on the number of CEs that can be enchanted on an item(can be configured in config), because having more than 8 CEs make the item very overpowered, even the working chances of the enchantments are lowered down in the config.

If you can't update the plugin furthermore with this feature being added, please consider at least telling me how to try to add the feature to the plugin(by coding extra stuff in) because I've tried it multiple times and all of them...yeah I messed it up lol

Thanks! Also be careful of corona!

Also for springs and gears(actually, all helpful effects), will it be possible so that I can configure the levels that you get when wore?

Thunder33345 commented 4 years ago

this should be done on your enchanting/enchant shop plugin

minijaham commented 4 years ago

this should be done on your enchanting/enchant shop plugin

Yes, but I want most of the CEs that PiggyCustomEnchants support :(

Thunder33345 commented 4 years ago

what i mean is the limit should be configured in the enchanting plugin example, enchant sign, has a limit of 3, that means it check for 3 ce, if it has more, dont enchant it doesn't make any architectural sense sense for this limit to be done in the CE what if i as a dev wanna add more? what if i wanna overwrite it? this doesnt make sense

Thunder33345 commented 4 years ago

oh shoot wrong github link lol sorry I was gonna put this in the CustomEnchants not the shop

Learn to read previous reply, even you said it's a duplicate. Why not try to read the previous response?

You're better off having the limit on what's applying the enchants instead of directly in the core, seems kind of pointless here

it WILL NOT be added to the core it does not make sense to be added in the core if your enchanting plugin does not support limits, go nag them in the correct place, not piggyCE