DaPigGuy / PiggyShopUI

An easy to use shop UI plugin for PocketMine-MP
Apache License 2.0
15 stars 18 forks source link

A permission doesn´t exists #35

Closed ghost closed 3 years ago

ghost commented 3 years ago

Issue Description

Steps to Reproduce the Issue

  1. Create a category with any name (e.g food) and put it private
  2. Give a player the permission piggyshopui.category.food
  3. Try to access to that category with the user that "has" the permission
  4. Type /fperms PiggyShopUI
  5. Get realised that PiggyShopUI doesn´t have a permission called "piggyshopui.category." as seen on poggit page

    OS and Versions

    • PocketMine-MP: 3.21.0
    • PiggyShopUI: 2.1.1
    • PHP: wtf
    • Server OS: Pocketmine

The permission "piggyshopui.category." doesn´t exists, as seen on poggit page

image

imagen_2021-06-24_182312

Aericio commented 3 years ago

See https://github.com/DaPigGuy/PiggyShopUI/blob/master/src/DaPigGuy/PiggyShopUI/shops/ShopCategory.php#L41-L42

Aericio commented 3 years ago

Might be a configuration error, since there were no API changes with permission registering and it was confirmed to work. I don't think anything is wrong here.

If we can get another person to confirm that there are issues, then I'll re-open the issue and look into it whenever I have time.