search

Daanoz / ha-google-photos

Home Assistant Google Photos integration
MIT License
87 stars 7 forks source link

Migrate to new Image Entity #33

Closed stboch closed 1 year ago

stboch commented 1 year ago

Is your feature request related to a problem? Please describe. Home-Assistant 2023.7 added support for Image Entity... https://www.home-assistant.io/blog/2023/07/05/release-20237/#image-entities

Describe the solution you'd like Migrate from Camera entity to image entitty. Hopefully this will reduce complexity and allow for new cooler features going forward.

Daanoz commented 1 year ago

I looked into this, the main issue here is that the call to retrieve the image is not provided with the contextual dimensions. This would basically force the integration to always give back the highest resolution image without any cropping possibilities. Also if I every get to implementing the retrieval of videos, this would probably not work with the image entity.

All in all, only downsides at the moment, but willing to revisit this once there is a nice use case.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.