Daanoz / ha-google-photos

Home Assistant Google Photos integration
MIT License
87 stars 7 forks source link

Resolution does not scale with pixel density, resulting in blurry pictures on high-density screens #45

Closed JiDW closed 5 months ago

JiDW commented 9 months ago

Hello!

I am using your (amazing) integration for my lovelace wallpanel screensaver on a Pixel Tablet. I tried to troubleshoot why my pictures were blurry, and after some tests I believe it is because the integration is downloading pictures with a resolution based on the CSS resolution (1280x800) instead of the device pixel resolution (2560x1600)

I confirmed this by enabling the debug log and looking at the picture downloaded.

Is that something you can fix on your end? I'm not sure if it is an issue with camera entity in HA or with your camera code, as I do not know how the width/height of the screen is retrieved. Either way, I'm open to suggestions if a fix is not possible in the integration.

Thanks!

github-actions[bot] commented 8 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

JiDW commented 8 months ago

Not stale, good bot o/

Daanoz commented 6 months ago

I've not yet been able to reproduce your issue. The dimension to be requested is set by the HA frontend code, which looks like it is taking the pixel ratio into account. Do you have other integrations that display the resolution correctly?

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.