search

Daanra / laravel-lets-encrypt

Let's Encrypt wrapper for Laravel
MIT License
206 stars 28 forks source link

[Feature Request] Subject Alternative Names #22

Closed Muffinman closed 2 years ago

Muffinman commented 2 years ago

Hi,

I'm wondering if this package supports sending SubjectAlternativeNames to LetsEncrypt / AcmePHP?

I can see that AcmePHP itself does have support for them, but I couldn't see any obvious references in this package.

EDIT: Our use case is for a multi-tenant Laravel application. we want one vhost per tenant rather than one per domain, so it makes sense to have a single SSL cert with all their active domains contained inside.

Daanra commented 2 years ago

It currently does not support SubjectAlternativeNames but this should be rather easy to implement.

I can probably release this in a couple of days.

Muffinman commented 2 years ago

That sounds excellent! Happy to send a PR or collaborate on this if it makes sense.

I did take a look but I couldn't see any way of doing it without breaking changes. I think it will need new parameters adding to methods.

Daanra commented 2 years ago

Feature added to v0.5.0