search

Daanra / laravel-lets-encrypt

Let's Encrypt wrapper for Laravel
MIT License
206 stars 28 forks source link

Adding subjectAlternativeNames support #23

Closed Muffinman closed 2 years ago

Muffinman commented 2 years ago

As discussed in #22, this PR adds subjectAlternativeNames support.

The following is currently untested, but just wanted to check direction before I go any further.

Daanra commented 2 years ago

Thanks for the effort!

I think it can be done without breaking changes by adding the SAN functionality to the PendingCertificate class.

For example:

LetsEncrypt::certificate('mydomain.com')
        ->subjectAlternativeNames(['mydomain2.com'])
        ->create();
Muffinman commented 2 years ago

Hi @Daanra,

I had just assumed those create() and createNow() methods on the Facade would have to be updated. If doing as you suggest this makes for a far simpler PR.

Daanra commented 2 years ago

@Muffinman Thanks, looks great!