Dabz / ccloudexporter

Prometheus exporter for Confluent Cloud API metric
https://docs.confluent.io/current/cloud/metrics-api.html
87 stars 53 forks source link

Use go modules #25

Closed sirianni closed 4 years ago

sirianni commented 4 years ago

Use go modules instead of legacy $GOPATH build.

Make some Dockerfile tweaks:

Dabz commented 4 years ago

Thanks a lot @sirianni for migrating to go module, that was something important to do! The image is building properly locally, so I will merge and this should kick-off a Dockerhub build.

It is worth noting that switching from CMD to ENTRYPOINT is actually a breaking change. Running ccloudexporter -cluster $CCLOUD_CLUSTER (previous way of running the ccloudexporter) would break the exporter :/

I guess it also highlights the fact that I do not have a proper versioning system in place yet :thinking: