search

Dabz / ccloudexporter

Prometheus exporter for Confluent Cloud API metric
https://docs.confluent.io/current/cloud/metrics-api.html
87 stars 53 forks source link

feat: Added `/health` endpoint #91

Closed raytung closed 3 years ago

raytung commented 3 years ago

Hey @Dabz :wave:

This should be a simple one - simply adding a /health endpoint so we're not rate limited by Confluent cloud when we're simply doing liveness and readiness check on the exporter. Fixes https://github.com/Dabz/ccloudexporter/issues/86

Thanks!

Dabz commented 3 years ago

Looks good to me, thanks a lot for the contribution @raytung!

raytung commented 3 years ago

Thanks for the quick look, @Dabz! Out of curiosity, would it be possible to publish a new Docker container image to Docker hub?

I'm more than happy to put up a pull request to setup some sorts of Github action if that's the preferred approach.

Dabz commented 3 years ago

Ohh, I used to rely on Docker Hub automated build, but this is a paid feature nowadays u.u I guess I will switch to Github action. I do have some free time today (which is uncommon ^^), I will set it up.

raytung commented 3 years ago

ah yeah, Docker did change their pricing model. Thanks a bunch for your work! :tada: Really appreciate it.

Dabz commented 3 years ago

For information, I added a Github action to push to dockerhub for each push on master. The latest image has been pushed :-)

raytung commented 3 years ago

Thank you! :smile: