Dabz / ccloudexporter

Prometheus exporter for Confluent Cloud API metric
https://docs.confluent.io/current/cloud/metrics-api.html
87 stars 53 forks source link

Remove forward slash from query endpoint #95

Closed kutysam closed 3 years ago

kutysam commented 3 years ago

If we look at here (for a different endpoint), We don't have the forward slash. https://github.com/Dabz/ccloudexporter/blob/master/cmd/internal/collector/descriptor.go#L66

Currently the API that is polled for query is https://api.telemetry.confluent.cloud//v2/metrics/cloud/query If confluent cloud changes their url parser, we may have an issue. Thus, lets remove the slash.

On Readme, the default api that is suggested is with a trailing slash.

Dabz commented 3 years ago

Fair point, let me merge it