search

DacoTaco / BarcodeParserBuilder

BarcodeParserBuilder is a .Net ( standard 2.0 & 2.1 ) nuget package to help parse & build barcode strings
https://www.nuget.org/packages/BarcodeParserBuilder
GNU Lesser General Public License v2.1
11 stars 4 forks source link

Having trouble adding application identifier for GLN (414). #17

Closed marydeshon closed 7 months ago

marydeshon commented 7 months ago

This is a great package! I added the GLN AI which is 414 fixed length of 13 to the field collection. In testing it fails to parse and seems to be that the AI is being parsed as 41 instead of 414. Is there something "special" I need to do for 3 char identifier on a fixed length field? I see all of the float versions so maybe something like that is needed? I am using ]d2 for tesing.

DacoTaco commented 7 months ago

hm, this probably has to do with the code currently kinda cheating and parsing all AI's starting with 41 as a random part

i think all 41x fields will need to be added properly and have its data type & length set just like what we did with 31x which were thankfully all double types

thankfully, a quick look at the list @ https://ref.gs1.org/ai/ seems to show all 41x AI's are string integers, so i think just having them defined as string will do.

to be correct though, we'd need to somehow read it in as a string that can only have digits, but that would need more work. as a first step, i think defining the AI's would get it going for now :)

will you be making a PR to implement these?

marydeshon commented 7 months ago

Thank you for your quickly response!I attempted a PR with just the field defines for 414 and 254. I was getting 403 errors but will try again tomorrow with help from my colleague.Sent from my iPhoneOn Mar 26, 2024, at 3:17 PM, DacoTaco @.***> wrote: hm, this probably has to do with the code currently kinda cheating and parsing all AI's starting with 41 as a random part i think all 41x fields will need to be added properly and have its data type & length set just like what we did with 31x which were thankfully all double types thankfully, a quick look at the list @ https://ref.gs1.org/ai/ seems to show all 41x AI's are string integers, so i think just having them defined as string will do. to be correct though, we'd need to somehow read it in as a string that can only have digits, but that would need more work. as a first step, i think defining the AI's would get it going for now :) will you be making a PR to implement these?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

DacoTaco commented 7 months ago

ye, 25x is the same. we read everything starting with 25 into the one field hehe

marydeshon commented 7 months ago

Hi I just created a pull request. Could you please review at your convenience. Thank you!!

DacoTaco commented 7 months ago

@marydeshon : PR is merged, thanks a lot! do you want me to create a new preview package to upload to nuget so you can use it?

marydeshon commented 7 months ago

Yes, please!

On Thu, Apr 4, 2024 at 5:01 PM DacoTaco @.***> wrote:

@marydeshon https://github.com/marydeshon : PR is merged, thanks a lot! do you want me to create a new preview package to upload to nuget so you can use it?

— Reply to this email directly, view it on GitHub https://github.com/DacoTaco/BarcodeParserBuilder/issues/17#issuecomment-2038211913, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZW5TILXTREU25CFYE655LY3W5SJAVCNFSM6AAAAABFJQSX52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYGIYTCOJRGM . You are receiving this because you were mentioned.Message ID: @.***>

DacoTaco commented 7 months ago

aight, a new tag has been created and pushed to nuget.org. 0.1.4-preview2 should be available in the next half hour :) thanks for your contribution !