Include Wiimmfi patch v1 in hacks_hash.ini

Leseratte10 commented 4 years ago

Here are the necessary changes to the hacks_hash.ini for Wiimmfi patcher support.

This includes patches for 4.1, 4.2 and 4.3, in all four regions (PAL, USA, JAP, KOR) each, plus patches for the PAL and NTSC versions of the Wii Mini 4.3. I didn't bother porting it to the four vWii versions because Priiloader doesn't run on there anyways; if Priiloader will ever run on vWii in the future I'll add these ports. Also I didn't bother porting it to 4.0 or below. If people still have a 4.0 or lower Wii in 2020, they should just update to 4.1 or newer.

This has been tested for PAL and USA discs, still needs some testers with JAP and KOR discs / consoles.

A couple things:

This patch patches all games for Wiimmfi that use the nintendowifi.net URLs. That probably includes the few Wii games that use their own online servers that are still up, these games probably won't be able to connect to their servers with this hack enabled.
The patch should work with Mario Kart Wii and the special patches required for that game, but it should also work with any other game supported by Wiimmfi.
~This patch requires the code changes from the Hacks_rework branch to be merged into master first before this will work.~ (already merged)

~Also, with that patch added the layout of the "Hacks" screen looks pretty bad, the "confirm" button overlays the last two hacks. I'd recommend either adding a way to scroll through that list, or to drop two of the rarely-used hacks from the hacks_hash.ini for the next release.~ (already fixed in master)

DacoTaco commented 4 years ago

this looks great ! i have a few remarks, but im loving this ! :)

i know about the hacks thing and i still need to fix it. its on my to do list (let me quickly make an issue about it)

InternalLoss commented 4 years ago

Currently trying these out with non-MKW games (since I know Leseratte doesnt have any to hand) - it seems currently that once I've saved my hacks and returned to System Menu, the wii menu will gladly load the disc with a patch, but once I go back to the main wii menu it crashes once a disc is inserted/the disc loads up to show banner.

as I did an upgrade install, I'm gonna try uninstalling and reinstalling to see if this persists. For reference, I have Wiimmfi Patch v1, Block Disc Updates, Block Online Updates (though a bit unnecessary nowadays), Move Disc Channel, Region-free EVERYTHING, Remove Diagnostic Disc Check, and disable no-copy hacks enabled (also, it seems exit to loader code is broken)

Leseratte10 commented 4 years ago

Yeah, I can confirm that. Dammit. There must be yet another difference between directly loading the system menu, and returning to the system menu from elsewhere.

Leseratte10 commented 4 years ago

Huh, it even breaks when I restart the Wii and the disc loads again - looks more like yet another issue with the new hacks system, not with my patch ... @DacoTaco it looks like the hack - again - only works when loaded from the Priiloader menu, and not when loaded through autoboot. at least sometimes.

Leseratte10 commented 4 years ago

Is it possible that the HBC loading stub - which apparently is also loaded at 80001800 when needed - is loaded into memory when you click "return to Wii menu" in any game? If that is loaded by Priiloader instead of the system menu hacks that are supposed to be loaded, then that stub would overwrite my patch that starts at 800018a8 ... Do I need to find another unused space for the Wiimmfi patch? 80001800 - 80003000 is all apparently used by the stub - but when exactly is it loaded?

I tried on Dolphin (and I had an older version of Priiloader installed in Dolphin) and saw the "STUBHAXX" code at 80001804, that's why I started looking into the stub ...

DacoTaco commented 4 years ago

very odd. the stub only loads on priiloader's startup and doesn't care after that (check LoadHBCStub in HomebrewChannel.cpp). priiloader is loaded when you press return to system menu , and it will overwrite your code in that region when starting up. however, when it boots system menu , after having detected a return to, it should reapply the patch. the loader also invalidates cache, so thats not a problem :/

i believe the stub area is a good area , and is proved by the gecko patch to be working , but something odd is wrong, ye

have you checked the memory in dolphin ? (if possible)

Leseratte10 commented 4 years ago

I did check the memory in Dolphin, but I only have an old version of Priiloader in Dolphin, and as far as I know you can't install it in Dolphin so I would need to install grab a new NAND backup from my Wii, and load it in Dolphin which messes up some custom stuff I did to my Dolphin NAND.

But I already found a potential workaround which seems to work more reliable. Wii games on non-devkit consoles are only allowed to have their DOL use the space between 80004000 and 80900000. The Wii system menu starts somewhere at 81xxxxxx. So I should be able to just load my patch to 80900000, and then when the game is booted and reuses that memory for something else then it doesn't matter anymore as the game will already be patched. It looks like this is more reliable than the 80001800 offset, so I'll re-compile all the patches for that offset and try again.

DacoTaco commented 4 years ago

why can't you install it? if you replace the app you get from the build on your nand backup in dolphin it should work afaik. (the app to replace on a 4.3E system menu is \title\00000001\00000002\content\0000009b.app)

Leseratte10 commented 4 years ago

Found another solution (hopefully) and pushed it into this merge request branch. At least on 4.3E it now seems to work reliably.